Skip to content

Refactoring magento sales sequence#19930

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
agorbulin:Refactoring-Magento_SalesSequence
Jan 4, 2019
Merged

Refactoring magento sales sequence#19930
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
agorbulin:Refactoring-Magento_SalesSequence

Conversation

@agorbulin
Copy link

@agorbulin agorbulin commented Dec 21, 2018

Description (*)

Refactoring in Magento_SalesSequence module

  • remove unused classes
  • enrich/fix PHPDocs

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

not needed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Aleksey Gorbulin added 2 commits December 21, 2018 16:57
Refactoring-Magento_SalesSequence
606e31c 
- remove unused classes
- enrich/fix PHPDocs
Refactoring-Magento_SalesSequence
bc2001f
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 21, 2018

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: SalesRule Component: SalesSequence Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Dec 21, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 21, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 21, 2018

Hi @sidolov, thank you for the review.
ENGCOM-3729 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 4, 2019

Hi @agorbulin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit bc2001f into magento:2.3-develop Jan 4, 2019
magento-engcom-team pushed a commit that referenced this pull request Jan 4, 2019
@sidolov
ENGCOM-3729: Refactoring magento sales sequence #19930
cc82f33
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 4, 2019

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 4, 2019

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@agorbulin agorbulin mentioned this pull request Jan 5, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels

Cleanup Component: SalesRule Component: SalesSequence Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@agorbulin @magento-engcom-team @sidolov